Michał Lipok

Results 163 comments of Michał Lipok

So do you whether you intend to close this ticket or mark it as `awaiting feedback` (gecko driver fix for FF)

Please treat this [PR: 384 _WD_LoadWait - better error handling](https://github.com/Danp2/au3WebDriver/pull/384) as separate things.

btw. I have also a plan to: Add support for checking all frames in `_WD_LoadWait` but firstly [362 _WD_FrameList](https://github.com/Danp2/au3WebDriver/pull/362) must be merged.

In my opinion `$iExt` is also related to ERROR handling. EDIT: Also `$sMessage` usage is related to ERROR handling.

> IMO those changes are related more to logging / debugging than error handling. Agree. But this was my intention so I change the PR title to be more in...

you can assign this issue to me

> I think we should provide new feature for `_WD_LoadWait()` as there can be cases that you would like to wait not for `complete` but for `interactive` or even `loaded`...

> btw. I have also a plan to: Add support for checking all frames in `_WD_LoadWait` but firstly [362 _WD_FrameList](https://github.com/Danp2/au3WebDriver/pull/362) must be merged. this part is still required to be...

@Danp2 Before I proceed with further work on this functionality, please check if you will initially accept it.

Please check it with modified [wd_demo.au3](https://github.com/Danp2/au3WebDriver/pull/386/commits/b7712f77aa1899ff72192a76828a253be8d5368f)