Michał Lipok

Results 163 comments of Michał Lipok

I think that it should be taken as normal and despite everything (even in the case of an error), try to return the result that has been correctly processed so...

> I think that it should be taken as normal and despite everything (even in the case of an error), try to return the result that has been correctly processed...

> you can't gather data on an element that doesn't yet exist ..... or disappeared during processing.

> Currently I wonder if this javascript snippet > > ```js > document.querySelector("body > print-preview-app").shadowRoot.querySelector("#sidebar").shadowRoot.querySelector("print-preview-button-strip").shadowRoot.querySelector("div > cr-button.action-button") > ``` > > will be handy in any way ? I still...

> @mlipok This appears related to #358. Can this one be closed? lets stick them separate. `#325` is about _WD_ElementOptionSelect usage `#353` is about JS usage

some reading https://developer.mozilla.org/en-US/docs/Web/API/ShadowRoot https://stackoverflow.com/a/34119775/5314940

https://www.autoitscript.com/forum/topic/208640-webdriver-udf-help-support-iv/?do=findComment&comment=1515550 wondering if such `readyState` checking is possible: ``` document.querySelector("body > print-preview-app").shadowRoot.querySelector("#sidebar").shadowRoot.document.readyState ```

> wondering if such `readyState` checking is possible: > > ``` > document.querySelector("body > print-preview-app").shadowRoot.querySelector("#sidebar").shadowRoot.document.readyState > ``` hm... I rethink this case and I think it was not related. But...

I like the current implementation. I think that from about a year there was no any issue with this. so IMHO we can close this issue.

There are some changes in: https://bugzilla.mozilla.org/show_bug.cgi?id=1700095 Maybe soon will be fixed. Related: https://bugzilla.mozilla.org/show_bug.cgi?id=1821628 https://phabricator.services.mozilla.com/D172416#5677925