Mike Linksvayer

Results 173 comments of Mike Linksvayer

Detecting markdownified licenses is pretty fragile but there may be ways to improve. I've created #578 to explore. Regarding https://github.com/IQAndreas/markdown-licenses/blob/66202b51f3cfa74d8008e395f89d403a7f5a27ed/gnu-lgpl-v3.0.md the reasons for not matching are at least - it...

Interesting idea @benbalter. Makes me think Redcarpet's StripDown renderer might get us there without round trip.

This is by design. When licensee sees a possible license indicator it is uncertain about, it does not make an overall license assertion. As mentioned in https://github.com/licensee/licensee/issues/555#issuecomment-1100929646= it conceivably could...

Licensee intentionally matches files with additional words because sometimes actual license files have additional words in their names. I imagine we could add `.sh` to https://github.com/licensee/licensee/blob/06f5719b119513e00af73f4a578ed1ec0bc53d16/lib/licensee/project_files/license_file.rb#L17 to exclude shell scripts...

Ignoring random file with `license` in the name if a more standard named file exists in the project sounds reasonable. There's already some prioritizaiton of some filenames (see the linked...

Another quick/just a thought: conceivably other project-specific assertions for license detection might be useful in the future beyond an ignorelist. Perhaps the file should be `.licensee.yml` which could initially only...

Yet another quick thought: I don't know of any prior art/other license tooling with this feature, but if it exists would be good to know about.

@benbalter sorry for delay, ❤️ this approach, looks good to go to me.

(Though I do still [wonder](https://github.com/licensee/licensee/pull/545#pullrequestreview-922344878) whether it ought to be possible to tell licensee to ignore a file named `LICENSE` or perhaps anything file currently [scored](https://github.com/licensee/licensee/blob/6b4871a3fc8854486f6af792cad5017cf69ae346/lib/licensee/project_files/license_file.rb#L35) above say `0.85`?)

Wouldn't `CC0-1.0 AND MIT` be accurate at the package level? See https://spdx.org/spdx-specification-21-web-version#h.jxpfx0ykyb60