pgn-viewer icon indicating copy to clipboard operation
pgn-viewer copied to clipboard

pgnPrint does not display intermediate positions anymore

Open xeyownt opened this issue 4 years ago • 2 comments

Hello,

I noticed that the print mode no longer shows intermediate boards as it used to do.

For instance:

    <div id="board"></div>
    <script>PGNV.pgnPrint('board',{ pgn: '1. f4 $220 e6 2. g4 Qh4 $220', theme: 'brown', pieceStyle: 'merida' });</script>

will only display the last board, although the PGN text will be cut between f4 and e6, as if the board would be displayed in between.

image

You can also reproduce the issue in the Configuration Builder. If you select Game Evergreen then Modus pgnPrint, you will see that the PGN is formatted such at to display boards in the text, but these boards do not appear. (note also that I sometimes get an exception pgn.js:6 Uncaught No legal move: e4 in the console when trying to reproduce that issue in the Configuration Builder).

xeyownt avatar Feb 08 '21 00:02 xeyownt

Thank you for reporting that bug. Seems to be a consequence of the many changes to the layout ... Have to check if an easy fix is possible. Print was not my major use case, though.

mliebelt avatar Feb 08 '21 06:02 mliebelt

Ok, some analysis about the current bug (based on file /examples/modes/print/print1.html)

  • outerBoard should not be printed at all (that is the board above). Have to fix that in CSS. :heavy_check_mark:
  • configuration of everything overwrites the board configuration :heavy_check_mark:
  • CSS for printing does not fit to the rest
  • multi-column examples are mostly broken

mliebelt avatar Feb 10 '21 18:02 mliebelt