Wojak
Right, the number of missing exponent is not constant, the fix above will work for OSMO/USDC but for other pair like ETH/WBTC, it will not work, since the missing exponent...
I've updated the FIXME content as follow: https://github.com/hummingbot/gateway/blob/19e25b60d4131e03ba9ccde8c7045f543c706730/src/chains/osmosis/osmosis.ts#L1363-L1365 The calculation in `findTickForPrice` is not correct for price less than 1. For the scope of the bounty, I think it is...
I added new price to tick calculation here: https://github.com/hummingbot/gateway/pull/318/commits/ed45375755053179932fa17191abdd81d3d22368 Basically it is a rewrite from https://github.com/osmosis-labs/osmosis/blob/0f9eb3c1259078035445b3e3269659469b95fd9f/x/concentrated-liquidity/math/tick.go#L160 I also check the math in https://docs.osmosis.zone/osmosis-core/modules/concentrated-liquidity/#ticks and the calculation I implemented should check...
Look like they updated the calculation for tick: https://github.com/osmosis-labs/osmosis/blob/main/x/concentrated-liquidity/math/tick.go#L202 Did you add this update yet? I can't find it anywhere in the `development` branch. @chasevoorhees
@emusol Probably we need to debug here: https://github.com/hummingbot/gateway/blob/4afa163bb0a8d18a838209cdca10878cb0a25bf7/src/connectors/uniswap/uniswap.lp.ts#L57-L60 You got the error because the connector saw there are reject from the request promises that it made from the above code,...
Add new scope for this issue: >when adding a position HB dont recognize it(its a new issue, before it recognized it and just failed to get the position at one...
Hey @fengtality @nikspz, I have worked with @emusol and we agreed that we will set acceptance criteria as follow: - We will run his script and make sure there is...
Hey @nikspz, I will add tests to meet coverage requirement and some more updates to finalize the solution, probably finish by the end of this weekend.
I don't think the issue is because of async/await. You should implement `getTokens()` function in `near.controllers.ts` since there is no `getTokens()` function there hence the error for `chain/tokens` request.
Hey @nikspz, thanks for testing it. I added new code to address the issues you found in above comments, could you test it again?