mlfoundations
Update requirements.txt
transformers seems to be required to use open_clip, not just for training. see https://github.com/mlfoundations/open_clip/blob/60534f4774b11a2532536f3f264a666f11fbb6b6/src/open_clip/hf_model.py#L102
This is an optional dependency and is only required to use models from huggingface.
While it is optionally used at runtime, it still should be included to be able to resolve dependencies e.g. in requirement lock files
I think it would make sense to simply clarify the error to explain to the user they need to install transformer dependency if they use models coming from huggingface.
On Sat, Dec 17, 2022, 02:09 August Karlstedt @.***> wrote:
While it is optionally used at runtime, it still should be included to be able to resolve dependencies e.g. in requirement lock files
— Reply to this email directly, view it on GitHub https://github.com/mlfoundations/open_clip/pull/298#issuecomment-1355897121, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR437UWB55Q57YFSKJNLT3WNUHGBANCNFSM6AAAAAATAESNOQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
