open_clip icon indicating copy to clipboard operation
open_clip copied to clipboard

Add non regression tests

Open rom1504 opened this issue 3 years ago • 11 comments

To make it easier to merge PRs in the future, we need automated non regression tests

  • In GitHub action
  • on CPU

Tests to have:

  • [x] exact inference result before/after
    • [x] non crashing inference
    • [x] non reg : wip at 199
  • [ ] can still load with torch.load
  • [ ] training works the same before after, for one step, same weights and results
    • [x] non crashing training
    • [ ] non reg

rom1504 avatar Nov 03 '22 10:11 rom1504

@Iopho if you want to help here, it would be appreciated

rom1504 avatar Nov 03 '22 10:11 rom1504

I made some time tomorrow and will start writing tests.

lopho avatar Nov 03 '22 18:11 lopho

@rom1504 I opened a PR draft for inference testing #199

lopho avatar Nov 04 '22 20:11 lopho

non crashing training test done at #203, non reg still to do

rom1504 avatar Nov 07 '22 19:11 rom1504

Non reg inference tests done, thanks @lopho

Next step here is non reg test for training

rom1504 avatar Nov 12 '22 17:11 rom1504

Still very much interested by the non reg for training if you feel like continuing work here @lopho Develoment is still active and if we can make sure we don't break things going forward it will be great

rom1504 avatar Nov 23 '22 18:11 rom1504

Yes, I'm still working on it. Before training I still have to look into making testing more stable regarding randomness between runs, as I think this will be worse with training tests.

lopho avatar Nov 24 '22 11:11 lopho

Looks like inference testing is working very well with your new strategy @lopho

Do you want to look into training non reg as well ?

We have a few PRs with significant changes and it would be very helpful if we can be confident that base clip training is still doing exactly the same thing

rom1504 avatar Dec 18 '22 14:12 rom1504

Definetly, but I won't have time to until after new years.

lopho avatar Dec 18 '22 18:12 lopho

I will start working on this again within the next week, unless there is already someone working on it that I am not aware of.

lopho avatar Jan 24 '23 10:01 lopho

@lopho would be great. We're still in need of more reliability for merging PRs! Currently doing manual training for validation which is painful

rom1504 avatar Jan 28 '23 09:01 rom1504