Michael Lenzen comments

Results 18 comments of


                                            Michael Lenzen

Add annotations

Need to create a unique type for each Sentinel so that we can add that type to the annotation.

Add annotations

Need to use backported typing library for Python

Each of keys() and values() both return the whole rangeMap, meaning keys AND values

Hi @RemKamal , what version are you using and can you post a code example? You should get a `RangeMapKeysView` and a `RangeMapValuesView`

Consistent use of item, elem or value

`item` should be used for tuples of key, index & value. The math language has been mostly removed in favor of more generic programming terms, e.g. bag instead of multiset,...

This is an interesting idea. Regarding implementation, I've been thinking about making RangeMap return views of the underlying data instead of copies (#76). I think that implementation could also be...

Ignore C812 when all items are on one line

I personally use black but we don't enforce it's use by all developers. The linting rules are our standard.

python 3 support

FYI, I've ported nflgame to Python3: https://github.com/mlenzen/nflgame It runs without error in 2.7.9 and 3.4.3 but I haven't compared outputs (yet) or written tests. I also switched to requests instead...