mlem icon indicating copy to clipboard operation
mlem copied to clipboard

Performance issues when expanding comments with many child comments

Open boscojwho opened this issue 1 year ago • 2 comments

Describe the bug When expanding comment with many child comments, main thread appears to be blocked.

Expected Behavior Should bounce that work off on background thread, and have a progress indicator show while that's happening.

Actual Behavior Comment expansion is blocking main thread.

To Reproduce

  1. Open post with comment with hundreds of replies.
  2. Collapse/expand that comment.

Mlem Information:

  • Latest commit on /dev branch.

boscojwho avatar Jan 07 '24 02:01 boscojwho

I can take a look at this after #841 is merged in =)

boscojwho avatar Jan 07 '24 02:01 boscojwho

Looks like the issue is the animation itself--I can't find any Mlem code that's running particularly slowly. We probably shouldn't be animating the whole thing, though--something to look into for 2.0

EricBAndrews avatar Apr 25 '24 21:04 EricBAndrews

Fixed in 2.0

Sjmarf avatar Jan 18 '25 09:01 Sjmarf