SlickGrid icon indicating copy to clipboard operation
SlickGrid copied to clipboard

Some events added to increase plugin power

Open hakancunier opened this issue 9 years ago • 1 comments

Hi,

I wrote many custom plugins for SlickGrid a while ago. Finally i have upgraded to your fork. But my plugins and some other libraries which are working with SlickGrid need some extra events. I added them to slick.grid.js and If you accept i want to share it. These are also required to make SlickGrid sub totals plugins to work slick.grid.js.zip

when editing.

hakancunier avatar Feb 17 '16 21:02 hakancunier

I'd like to do this. After a quick review, I've got these comments:

  • I prefer 'afterRender' (which allows for 'beforeRender') although 'onRendered' does somewhat imply 'after'
  • similarly I think 'onInitialize' should be either 'onInitialized' or even better 'afterInitialize'
  • not sure of the usage of 'onOutsideGridClick', I think other libraries (eg. drag/drop) are used to fulfil similar functions, although there's been talk of removing these. All in all, I think it potentially has quite a sizeable impact on the rest of the page given all nodes receive the event. I'd be happy to include this with a default-off switch, such as option.TrackOutsideClick to allow you to easily activate it, but not have it on by default.

These are all preferences, not a cast-iron demand. Would these mods be accepatable or would it impact on too much stuff ?

6pac avatar Feb 26 '16 08:02 6pac