power-dev icon indicating copy to clipboard operation
power-dev copied to clipboard

Recent changes add whitespace line at the end of spl.txt files

Open psyhtest opened this issue 1 year ago • 1 comments

A companion to https://github.com/mlcommons/inference/issues/1581

A workaround is provided with two PRs:

  • https://github.com/mlcommons/power-dev/pull/325
  • https://github.com/mlcommons/inference/pull/1584

This will work for v4.0 submitters who have already generated some experiments.

Ideally, we should locate the change that altered the file structure, and amend it.

psyhtest avatar Jan 26 '24 11:01 psyhtest

Thank you @psyhtest This is the location of the issue and we can fix it after the submission deadline so that checksum won't change for 4.0 submissions.

Another action item is to run the checker on any PR to the power-dev repository via Github actions - currently the power workflow is run but not the checker.

arjunsuresh avatar Jan 26 '24 11:01 arjunsuresh