mobile_app_open icon indicating copy to clipboard operation
mobile_app_open copied to clipboard

fix: resolve crash on Play Store version

Open anhappdev opened this issue 1 year ago • 20 comments

  • Closes https://github.com/mlcommons/mobile_app_open/issues/893

anhappdev avatar Jun 22 '24 02:06 anhappdev

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

github-actions[bot] avatar Jun 22 '24 03:06 github-actions[bot]

@anhappdev do you want me to try out this version of the app from the playstore?

mohitmundhragithub avatar Jun 24 '24 05:06 mohitmundhragithub

@anhappdev do you want me to try out this version of the app from the playstore?

Yes. Please.

anhappdev avatar Jun 24 '24 06:06 anhappdev

@anhappdev do you want me to try out this version of the app from the playstore?

Yes. Please.

i see the play store version was updated on 18th June. Can you push the apk with these fixes as well to playstore?

mohitmundhragithub avatar Jun 24 '24 08:06 mohitmundhragithub

i see the play store version was updated on 18th June. Can you push the apk with these fixes as well to playstore?

@mohitmundhragithub I am not sure why it shows that date. Can you check the app build number in the settings screen. The build number from this PR should be 156?

anhappdev avatar Jun 24 '24 10:06 anhappdev

the latest version that i downloaded is 156 only.

Screenshot_20240624_161603.jpg

but sadly, this also doesn't work.

mohitmundhragithub avatar Jun 24 '24 10:06 mohitmundhragithub

@mohitmundhragithub Ok. Thanks for the feedback. Is the crash occurred on any Android devices with the QTI backend or only on the Galaxy S23?

anhappdev avatar Jun 24 '24 10:06 anhappdev

I tried the apk on another device (Samsung galaxy tab s8+, SD8Gen1). It crashes there as well.

Sadly I am still unable to upload the device logs... but following up with IT team internally.

mohitmundhragithub avatar Jun 24 '24 10:06 mohitmundhragithub

@anhappdev please add [email protected] for internal testing

freedomtan avatar Jun 25 '24 05:06 freedomtan

Galaxy S23 Ultra.txt

Hi Anh,

Finally able to upload the logs. Can you please check?

mohitmundhragithub avatar Jun 28 '24 03:06 mohitmundhragithub

Galaxy S23 Ultra.txt

Hi Anh,

Finally able to upload the logs. Can you please check?

It looks like the same issue we have here: https://github.com/mlcommons/mobile_app_open/pull/859#issuecomment-1969462799

For this issue, I still cannot find a solution.

anhappdev avatar Jul 02 '24 03:07 anhappdev

actually the symptom (final log) for failure is same. But the reason would be different. Seems like when uploading to playstore, the DSP access gets denied but not otherwise.

Seems like we are missing some checks when uploading to playstore?

mohitmundhragithub avatar Jul 02 '24 03:07 mohitmundhragithub

Let's see if we can

  1. aab (in the CI) -> apk
  2. try to get technical support from Play Store?
  3. @freedomtan to try on MTK devices (or Samsung devices).

freedomtan avatar Jul 02 '24 05:07 freedomtan

Works on

  • MTK devices: both newer .dla and older TFLite Neuron Delegate work
  • Pixel 8 Pro: works

@AhmedTElthakeb and @Mostelk: please check if the Play Store apk works on Exynos devices.

freedomtan avatar Jul 02 '24 09:07 freedomtan

I opened a support ticket on Google Play, but they don't provide support for this kind of issue. Here is their answer:

Thanks for reaching out to Google Play Technical Support. Although I’m happy to answer any questions about managing your apps on the Google Play Console, our team isn’t trained to provide technical support for app development questions.

anhappdev avatar Jul 06 '24 04:07 anhappdev

@AhmedTElthakeb will try to run the in Play Store one w/ SELinux disabled (if that works, we are almost sure that there is some kind of permission setting problem).

freedomtan avatar Jul 16 '24 05:07 freedomtan

I don't know if it makes a different, but I deployed the app to the closed testing channel. Compared to the internal testing channel, a user still needs to be invited to join the testing program (so it's not public), but the app is reviewed by Google on every release, so I hope maybe the app will not be classified as "untrusted app" anymore.

@mohitmundhragithub @AhmedTElthakeb Can you please test the app (v4.1.0 (164)) again: https://play.google.com/apps/testing/org.mlcommons.android.mlperfbench

anhappdev avatar Jul 22 '24 10:07 anhappdev

I don't know if it makes a different, but I deployed the app to the closed testing channel. Compared to the internal testing channel, a user still needs to be invited to join the testing program (so it's not public), but the app is reviewed by Google on every release, so I hope maybe the app will not be classified as "untrusted app" anymore.

@mohitmundhragithub @AhmedTElthakeb Can you please test the app (v4.1.0 (164)) again: https://play.google.com/apps/testing/org.mlcommons.android.mlperfbench

didn't work on GS23Ultra.

mohitmundhragithub avatar Jul 22 '24 10:07 mohitmundhragithub

on rooted device, adb shell then setenfoce 0, and adb shell setenforce 0 (meaning disabling all the permission checks by the SELinux). @mohitmundhragithub and @AhmedTElthakeb

freedomtan avatar Aug 27 '24 05:08 freedomtan

I think I found one workaround for the issue.

For QTI backend, if we push few of the dependent libs to the "files" folder, instead of packing it in the apk's "lib" folder, then the issue gets resolved for qti backend. I want to try it out for the app to be downloaded from the play store.

@anhappdev, i will push a change to this PR... can you please help to push the aab file to the playstore? i can test with that.

mohitmundhragithub avatar Oct 24 '24 09:10 mohitmundhragithub

@mohitmundhragithub You can just push directly to this branch anh/debug-play-store-version. The CI will deploy the AAB to Play Store automatically.

anhappdev avatar Oct 24 '24 10:10 anhappdev

It will also reopen the PR.

anhappdev avatar Oct 24 '24 10:10 anhappdev

@mohitmundhragithub You can just push directly to this branch anh/debug-play-store-version. The CI will deploy the AAB to Play Store automatically.

@anhappdev , the app got deployed to play store successfully, but the date in play store still shows 21st july. How long does it take to update?

mohitmundhragithub avatar Oct 24 '24 11:10 mohitmundhragithub

@anhappdev , the app got deployed to play store successfully, but the date in play store still shows 21st july. How long does it take to update?

I don't know that. And I don't know if that date get updated. But you can check the build number displayed in the app settings screen to make sure it's the expected version.

anhappdev avatar Oct 24 '24 12:10 anhappdev

it says version: 4.1.0 | build: 164... which seems to be same as before :(

mohitmundhragithub avatar Oct 24 '24 12:10 mohitmundhragithub

@anhappdev , the app got deployed to play store successfully, but the date in play store still shows 21st july. How long does it take to update?

I don't know that. And I don't know if that date get updated. But you can check the build number displayed in the app settings screen to make sure it's the expected version.

@anhappdev, can you please push it manually?

mohitmundhragithub avatar Oct 24 '24 12:10 mohitmundhragithub

@anhappdev, can you please push it manually?

The app 4.1.0 (245) is available on the internal track. Maybe you can try delete and reinstall the current version on your phone?

anhappdev avatar Oct 24 '24 13:10 anhappdev

@anhappdev, can you please push it manually?

The app 4.1.0 (245) is available on the internal track. Maybe you can try delete and reinstall the current version on your phone?

https://play.google.com/store/apps/details?id=org.mlcommons.android.mlperfbench&pcampaignid=web_share

Is this the correct link? Somehow for my account, its not showing the correct version. I tried unisntalling / installing again on multiple devices.

mohitmundhragithub avatar Oct 24 '24 15:10 mohitmundhragithub

@anhappdev, can you please push it manually?

The app 4.1.0 (245) is available on the internal track. Maybe you can try delete and reinstall the current version on your phone?

https://play.google.com/store/apps/details?id=org.mlcommons.android.mlperfbench&pcampaignid=web_share

Is this the correct link? Somehow for my account, its not showing the correct version. I tried unisntalling / installing again on multiple devices.

may be it takes some time to reach my region (india). will wait for some more time.

mohitmundhragithub avatar Oct 24 '24 15:10 mohitmundhragithub