medperf icon indicating copy to clipboard operation
medperf copied to clipboard

[FEATURE] A command to edit entities

Open hasan7n opened this issue 3 years ago • 7 comments

Add a command to edit entities (benchmarks, mlcubes, datasets). Example: medperf mlcube edit --uid <uid> --key val

This is related to #44 where users should have the option to change their dataset's state to OPERATION.

hasan7n avatar Dec 20 '22 17:12 hasan7n

we can also have a command medperf <entity> deploy that edits state to "OPERATION"

hasan7n avatar Dec 22 '22 15:12 hasan7n

This requires us to know what's the edition requirements, or entity state machine.

aristizabal95 avatar Jan 30 '23 17:01 aristizabal95

To discuss with @msheller

aristizabal95 avatar Feb 06 '23 16:02 aristizabal95

@hasan7n create an example using one of the entities

hasan7n avatar Feb 21 '23 15:02 hasan7n

encapsulate "permissions" of editing (whether the requested field can be edited or not based on state). We can later modify these rules after we finalize the state machine.

Also, there no need for now to modify the server logic of handling editing

Focus on the client side logic

hasan7n avatar Mar 20 '23 16:03 hasan7n

Open issues: Permissions for editing (how and when) Checking for reproducibility of MLCubes after a change. Do output artifacts change? How to test this robustly?

aristizabal95 avatar Nov 06 '23 16:11 aristizabal95

So editing mode reproduces the same logic (and CLI command) as medperf mlcube submit with the following changes:

  • only for mlcube
  • only for development mode
  • uid field is required
  • other fields (as in submit commands) are optional

VukW avatar May 21 '24 14:05 VukW