logging icon indicating copy to clipboard operation
logging copied to clipboard

package_checker creates file scaling.json in result directory

Open plvlnisse opened this issue 3 years ago • 2 comments

When running the package checker to check for a valid MLPerf training submission, the package_checker leaves a file scaling.json in the results/.../maskrcnn directory. This file makes the submission directory invalid for submission it seems.

python3 -m mlperf_logging.package_checker Final/Lenovo training 2.1.0 --rcp_bert_train_samples

plvlnisse avatar Oct 12 '22 16:10 plvlnisse

I think this is because of #271 . You can certainly get rid of these files before creating submission with something like: find <submission folder> -type f -name 'scaling.json' -delete .

We can also add a flag to the package checker to prevent creation of these scaling.json files (or disable by default and flag to enable), however the scaling.json files must be present to ensure the results summarizer produces accurate normalized scores.

@pgmpablo157321 @emizan76 what do you think, does it make sense to add such a flag to the package checker ?

maanug-nv avatar Oct 12 '22 19:10 maanug-nv

@maanug-nv I think for now the default value of the flag should be to not create such files. That way it wont mess any submission by accident, we can call the package checker with the flag in the submission UI

pgmpablo157321 avatar Oct 12 '22 19:10 pgmpablo157321