logging icon indicating copy to clipboard operation
logging copied to clipboard

Results summarizer fails when results folder is empty

Open pgmpablo157321 opened this issue 3 years ago • 0 comments

This error occurs:

Traceback (most recent call last):
File "/opt/python3.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/opt/python3.9/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/layers/google.python.pip/pip/lib/python3.9/site-packages/mlperf_logging/result_summarizer/__main__.py", line 3, in <module>
result_summarizer.main()
File "/layers/google.python.pip/pip/lib/python3.9/site-packages/mlperf_logging/result_summarizer/result_summarizer.py", line 626, in main
_update_summaries(args.folder)
File "/layers/google.python.pip/pip/lib/python3.9/site-packages/mlperf_logging/result_summarizer/result_summarizer.py", line 597, in _update_summaries
strong_scaling_summary, weak_scaling_summary = summarize_results(
File "/layers/google.python.pip/pip/lib/python3.9/site-packages/mlperf_logging/result_summarizer/result_summarizer.py", line 517, in summarize_results
strong_scaling_scores = _compute_strong_scaling_scores(
File "/layers/google.python.pip/pip/lib/python3.9/site-packages/mlperf_logging/result_summarizer/result_summarizer.py", line 330, in _compute_strong_scaling_scores
benchmark_scores[benchmark] = _compute_olympic_average(
File "/layers/google.python.pip/pip/lib/python3.9/site-packages/mlperf_logging/result_summarizer/result_summarizer.py", line 185, in _compute_olympic_average
return sum_of_scores * 1.0 / len(countable_scores)
ZeroDivisionError: float division by zero

A suggested solution would be to add a previous check in package checker to avoid this "ugly" error

pgmpablo157321 avatar May 18 '22 18:05 pgmpablo157321