inference icon indicating copy to clipboard operation
inference copied to clipboard

Update format.yml | Improve the github action

Open arjunsuresh opened this issue 1 year ago • 3 comments

arjunsuresh avatar Oct 08 '24 21:10 arjunsuresh

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

github-actions[bot] avatar Oct 08 '24 21:10 github-actions[bot]

@pgmpablo157321 Please review these changes - should fix the code formatter GH action.

arjunsuresh avatar Oct 08 '24 22:10 arjunsuresh

@mrmhodak @pgmpablo157321 can we merge this PR? This is blocking the #1884

nvzhihanj avatar Oct 22 '24 17:10 nvzhihanj

@arjunsuresh I tested it in my fork of the repo, the workflow seem to run, but I don't see the format changes pushed https://github.com/pgmpablo157321/inference/pull/5

pgmpablo157321 avatar Oct 29 '24 15:10 pgmpablo157321

Thank you @pgmpablo157321 for testing. I have fixed it by adding a missing git fetch.

arjunsuresh avatar Oct 29 '24 15:10 arjunsuresh

Tested again and now it works fine in my fork

pgmpablo157321 avatar Oct 29 '24 15:10 pgmpablo157321