croissant icon indicating copy to clipboard operation
croissant copied to clipboard

`schema:Enumerations` does not exist

Open VladimirAlexiev opened this issue 1 year ago • 2 comments

https://github.com/mlcommons/croissant/blob/main/docs/croissant.ttl:

croissant:ContentExtractionEnumeration a rdf:Class ;
  rdfs:label "ContexExtractionEnumeration" ;
  rdfs:comment "Specifies which content to extract from a file. One of \"all\", \"lines\", or \"lineNumbers\"." ;
  rdfs:subClassOf schema:Enumerations .

But there is no https://schema.org/Enumerations, there is https://schema.org/Enumeration.

Please fix this, and also collect all references to Schema terms and check them for existence.

VladimirAlexiev avatar May 15 '24 11:05 VladimirAlexiev

Thanks for the catch! Indeed it should be schema.org/Enumeration. Do you want to send me a PR for the fix, or should I go ahead and fix it?

benjelloun avatar May 15 '24 12:05 benjelloun

I grepped all schema terms

perl -ne 'print qq{$1\n} while m{(schema:\w+)}gc' *.ttl|sort|uniq -c          
    2 schema:Boolean                                                          
    1 schema:CreativeWork                                                     
   23 schema:Dataset                                                          
    1 schema:DateTime                                                         
    2 schema:Enumerations                                                     
    7 schema:Intangible                                                       
    1 schema:StructuredValue                                                  
   29 schema:Text                                                             
    2 schema:URL                                                              
    1 schema:distribution                                                     
   50 schema:domainIncludes                                                   
    1 schema:enumeration                                                      
   50 schema:rangeIncludes                                                    

And there's another misspelling: croissant:Split subClassOf schema:enumeration.

Please fix it, thanks!

VladimirAlexiev avatar May 15 '24 13:05 VladimirAlexiev