croissant icon indicating copy to clipboard operation
croissant copied to clipboard

Add schema.org sdLicense

Open mkuchnik opened this issue 1 year ago • 6 comments

Add a field for the metadata's license

See #544

mkuchnik avatar Feb 21 '24 02:02 mkuchnik

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

github-actions[bot] avatar Feb 21 '24 02:02 github-actions[bot]

https://schema.org/sdLicense is in the spec now. I set the sdLicenses to Apache 2.0, since the repository is Apache 2.0. sdLicense is either None or string for now.

Note: migration for bigcode-the-stack/metadata.json seems to have lost some information. I'm not sure if this is intended or not.

mkuchnik avatar Feb 23 '24 22:02 mkuchnik

@marcenacp The migration tool applies these changes even to v0.8, so I manually merged the diffs. Also, I think the migration tool may reorder the alphabetical order differently than a JSON formatter/linter, but this seems minor.

mkuchnik avatar Feb 26 '24 16:02 mkuchnik

@marcenacp Is there something that would block the merge if I rebased onto the current main?

mkuchnik avatar Mar 18 '24 18:03 mkuchnik

@Zack-83 They are schema.org fields so you can find the documentation on respectively https://schema.org/license and https://schema.org/sdLicense. Does this make sense to you? We could explicitly point to those URLs.

@mkuchnik Nothing blocks the merge on my side. Do you have all the rights for merge?

marcenacp avatar May 16 '24 11:05 marcenacp

@Zack-83 They are schema.org fields so you can find the documentation on respectively https://schema.org/license and https://schema.org/sdLicense. Does this make sense to you? We could explicitly point to those URLs.

@mkuchnik Nothing blocks the merge on my side. Do you have all the rights for merge?

@marcenacp thanks for considering my suggestion. I suppose that it would be useful to reference the URLs or disambiguate the two terms in another way at whatever position where the user inputs the license manually or where he/she gets some output, e.g. in the error messages of metadata.py.

Zack-83 avatar May 16 '24 15:05 Zack-83