fix is_cpu_op bug
Summary
Converting ASTRA-sim 1.0 text input files does not add is_cpu_op field. As a result, the COMM nodes are always skipped by the workload layer of astra-sim, as reported in https://github.com/mlcommons/chakra/issues/144 and https://github.com/astra-sim/astra-sim/issues/224.
Simply adding the attribute might fix the bug.
MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact [email protected].
0 out of 1 committers have signed the MLCommons CLA.
:x: @yue2388253
You can retrigger this bot by commenting recheck in this Pull Request
Thanks for your contribution, @yue2388253. We acknowledge this problem and would like to merge this in, once you sign the CLA form (https://drive.google.com/file/d/1SkpAdb3ka8tXepCawgGxAyo6cUH5ZAZg/view). Could you please do so?
Thanks for your contribution, @yue2388253. We acknowledge this problem and would like to merge this in, once you sign the CLA form (https://drive.google.com/file/d/1SkpAdb3ka8tXepCawgGxAyo6cUH5ZAZg/view). Could you please do so?
Hi @willjwon, I have submitted the CLA form as requested. Could you kindly review and confirm if the PR is ready for merging?
Thank you for your time and consideration.
Thanks for your contribution, @yue2388253. We acknowledge this problem and would like to merge this in, once you sign the CLA form (https://drive.google.com/file/d/1SkpAdb3ka8tXepCawgGxAyo6cUH5ZAZg/view). Could you please do so?
Hi @willjwon, I have submitted the CLA form as requested. Could you kindly review and confirm if the PR is ready for merging?
Thank you for your time and consideration.
@yue2388253 Hi, sorry for super late reply for you. May I ask your email that you've used to register? I also sent an email to MLCommons support team. Will let you know if there is any updates.
Thanks for your contribution, @yue2388253. We acknowledge this problem and would like to merge this in, once you sign the CLA form (https://drive.google.com/file/d/1SkpAdb3ka8tXepCawgGxAyo6cUH5ZAZg/view). Could you please do so?
Hi @willjwon, I have submitted the CLA form as requested. Could you kindly review and confirm if the PR is ready for merging? Thank you for your time and consideration.
@yue2388253 Hi, sorry for super late reply for you. May I ask your email that you've used to register? I also sent an email to MLCommons support team. Will let you know if there is any updates.
Just checked you are formally with the CLA @yue2388253 !
PR was held due to CLA issues, the same fix was made later in #180.
This is a duplicate of #180 so closing the PR.