Fix parent-child relationship issue in text2chakra_converter.py
Problem:
There was an AttributeError when attempting to add a parent node to a child node in text2chakra_converter.py. The issue occurred because the Node message in et_def.proto does not have a parent field.
Solution:
The fix involves using the existing ctrl_deps field to maintain parent-child relationships. Specifically, I modified the add_parent function to append the parent node's ID to the ctrl_deps field of the child node.
MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact [email protected].
1 out of 2 committers have signed the MLCommons CLA.
:white_check_mark: @TaekyungHeo
:x: @venkataramaraoguttikonda
venkataramaraoguttikonda seems not to be a GitHub user. You need a GitHub account after you become MLCommons member. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request
@venkataramaraoguttikonda thanks for the PR. you need to sign the CLA before we can proceed. Can you try the following:
- Join MLC Chakra WG https://mlcommons.org/working-groups/research/chakra/
- If that does not fix it - contact [email protected]
Thanks for your PR. You need to sign the CLA before we can proceed. Can you try the following:
- Join MLC Chakra WG
- If that does not fix it - contact [email protected]
@venkataramaraoguttikonda @TaekyungHeo Hi! This PR was made a while ago, and the code structure has changed significantly since then. Could you pull from main and try these changes again?
@venkataramaraoguttikonda Hi, in addition to the PR description, there is a lot of change from 'data dep' to 'crtl dep'. Could you also explain these changes/
Closing this PR. @venkataramaraoguttikonda please let us know if you'd like to re-open, and reply to the last question above related to data and ctrl dependencies.