chakra-old icon indicating copy to clipboard operation
chakra-old copied to clipboard

[ETFeeder] Update attrs to optional

Open changhai0109 opened this issue 1 year ago • 3 comments

Summary

For those optional attrs in chakra schema, we introduce std::optional to store attr fields, which can be used to indicate whether a attr exists or not. Also add helper functions to check if has this attr, also try_get with default values.

Test Plan

# setup codes
git clone [email protected]:changhai0109/astra-sim.git astra-sim
cd astra-sim
git checkout changhai-improve-workload-layer
git submodule update --init --recursive
cd extern/graph/chakra
git remote add folk [email protected]:changhai0109/chakra.git
git fetch folk && git checkout changhai-improve-workload-layer
cd ../../..

# at astra-sim dir
bash build/astra_analytical/build.sh 
cd runs/example/workload
bash downlaod.sh
cd ..
bash run.sh

Then have output:

[2023-12-06 13:07:36.952] [topology::RingTopology] [info] ring of node 0, id: 0 dimension: local total nodes in ring: 64 index in ring: 0total nodes in ring: 1
[2023-12-06 13:07:36.952] [topology::RingTopology] [info] ring of node 0, id: 0 dimension: local total nodes in ring: 64 index in ring: 0total nodes in ring: 1
[2023-12-06 13:07:36.952] [topology::RingTopology] [info] ring of node 0, id: 0 dimension: local total nodes in ring: 64 index in ring: 0total nodes in ring: 1
[2023-12-06 13:07:36.952] [topology::RingTopology] [info] ring of node 0, id: 0 dimension: local total nodes in ring: 64 index in ring: 0total nodes in ring: 1
[2023-12-06 13:07:43.851] [workload] [info] sys[0] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[1] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[2] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[3] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[4] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[5] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[6] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[7] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[8] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[9] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[10] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[11] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[12] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[13] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[14] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[15] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[16] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[17] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[18] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[19] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[20] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[21] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[22] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[23] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[24] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[25] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[26] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[27] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[28] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[29] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[30] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[31] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[32] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[33] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[34] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[35] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[36] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[37] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[38] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[39] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[40] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[41] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[42] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[43] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[44] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[45] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[46] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[47] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[48] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[49] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[50] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[51] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[52] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[53] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[54] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[55] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[56] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[57] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[58] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[59] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[60] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[61] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[62] finished, 1069447000 cycles
[2023-12-06 13:07:43.851] [workload] [info] sys[63] finished, 1069447000 cycles
[2023-12-06 13:07:43.854] [System] [info] Exiting

changhai0109 avatar Dec 06 '23 18:12 changhai0109

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

github-actions[bot] avatar Dec 06 '23 18:12 github-actions[bot]

@changhai0109 plz resolve conflicts. will review. we landed few changes recently.

srinivas212 avatar Dec 06 '23 23:12 srinivas212

Conflict resolved. @srinivas212

changhai0109 avatar Dec 07 '23 00:12 changhai0109