chakra-old
chakra-old copied to clipboard
[ETFeeder] Speedup et_feeder and resolve uninitialized attrs values in ETFeederNode
- Updated ETFeeder::readNextWindow to speed up by removing some extra resolveDeps() calls.
- Assigned default values of attrs in ETFeederNode to avoid uninitialized variables and leading undefined behavior with -O3 compile flag.
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅
This is a useful fix. ET feeder is being used by other downstream use cases and we need (a) unit test (b) before and after improvements. Thanks!
Moved the commit of changing et_converter output this PR, will submit another one later.