chakra-old icon indicating copy to clipboard operation
chakra-old copied to clipboard

[ETFeeder] Speedup et_feeder and resolve uninitialized attrs values in ETFeederNode

Open changhai0109 opened this issue 1 year ago • 3 comments

  1. Updated ETFeeder::readNextWindow to speed up by removing some extra resolveDeps() calls.
  2. Assigned default values of attrs in ETFeederNode to avoid uninitialized variables and leading undefined behavior with -O3 compile flag.

changhai0109 avatar Nov 21 '23 16:11 changhai0109

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

github-actions[bot] avatar Nov 21 '23 16:11 github-actions[bot]

This is a useful fix. ET feeder is being used by other downstream use cases and we need (a) unit test (b) before and after improvements. Thanks!

srinivas212 avatar Nov 22 '23 00:11 srinivas212

Moved the commit of changing et_converter output this PR, will submit another one later.

changhai0109 avatar Nov 22 '23 21:11 changhai0109