GaNDLF icon indicating copy to clipboard operation
GaNDLF copied to clipboard

Test coverage for `entrypoint` variable of mlcube deployment

Open sarthakpati opened this issue 2 years ago • 12 comments

@hasan7n: is there a way we can check this in the tests? We should perhaps discuss this in a separate issue, since this could perhaps be important.

Originally posted by @sarthakpati in https://github.com/mlcommons/GaNDLF/pull/730#discussion_r1391299090

sarthakpati avatar Nov 13 '23 15:11 sarthakpati

Stale issue message

github-actions[bot] avatar Jan 12 '24 19:01 github-actions[bot]

Hey @hasan7n could you please take a look at this?

sarthakpati avatar Jan 21 '24 15:01 sarthakpati

Stale issue message

github-actions[bot] avatar Mar 21 '24 19:03 github-actions[bot]

Hey @hasan7n can you take a crack at this?

sarthakpati avatar Mar 22 '24 13:03 sarthakpati

@VukW this should be fixed already with the new API branch, right?

sarthakpati avatar May 17 '24 15:05 sarthakpati

@sarthakpati No, this part was never touched in new API branch. To tell truth I don't get quite well even after reading parent PR what exactly is the issue about? What do we need to check?

VukW avatar May 20 '24 18:05 VukW

Ah okay. It is basically that these lines are not getting covered by tests:

image

And since this is (IMO) an integral part of the deploy mechanism, I would assume a test would need to updated/added to cover it. I was trying to ask clarification from @hasan7n but he hasn't responded this thread, yet.

sarthakpati avatar May 21 '24 02:05 sarthakpati

Are you talking about just a coverage of this line in deploy.py, or also about real check if container built with such an entrypoint would run properly?

VukW avatar May 21 '24 10:05 VukW

The coverage.

sarthakpati avatar May 21 '24 14:05 sarthakpati

Stale issue message

github-actions[bot] avatar Jul 20 '24 19:07 github-actions[bot]

@hasan7n - based on conversation about the metrics mlcube, do you think you could take care of this as well?

sarthakpati avatar Aug 21 '24 01:08 sarthakpati

Stale issue message

github-actions[bot] avatar Oct 20 '24 19:10 github-actions[bot]