Test coverage for `entrypoint` variable of mlcube deployment
@hasan7n: is there a way we can check this in the tests? We should perhaps discuss this in a separate issue, since this could perhaps be important.
Originally posted by @sarthakpati in https://github.com/mlcommons/GaNDLF/pull/730#discussion_r1391299090
Stale issue message
Hey @hasan7n could you please take a look at this?
Stale issue message
Hey @hasan7n can you take a crack at this?
@VukW this should be fixed already with the new API branch, right?
@sarthakpati No, this part was never touched in new API branch. To tell truth I don't get quite well even after reading parent PR what exactly is the issue about? What do we need to check?
Ah okay. It is basically that these lines are not getting covered by tests:
And since this is (IMO) an integral part of the deploy mechanism, I would assume a test would need to updated/added to cover it. I was trying to ask clarification from @hasan7n but he hasn't responded this thread, yet.
Are you talking about just a coverage of this line in deploy.py, or also about real check if container built with such an entrypoint would run properly?
The coverage.
Stale issue message
@hasan7n - based on conversation about the metrics mlcube, do you think you could take care of this as well?
Stale issue message