GaNDLF
GaNDLF copied to clipboard
mlcommons
Refactoring the code for some models
Is your feature request related to a problem? Please describe. There is currently quite some redundancy in the code for some models, and they could use some cleanup.
Describe the solution you'd like Geneal code refactoring based on a few points:
- Better variable names
- Improved readability of code
- Better logic flow for interpretability
Additionally, it would be good to encompass all "final model activations" (i.e., everything in this search) to be invoked in ModelBase as a separate member function, which should be called by other models. This will dramatically reduce code repetition.
Describe alternatives you've considered N.A.
Additional context N.A.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I think I have the code stashed right now. I will let you know by end of week.
@Geeks-Sid are you still working on this?
hey @Geeks-Sid are you still on this?
@Geeks-Sid are you still working on this?
hey @Geeks-Sid are you still on this?
hey @Geeks-Sid can you please confirm if you are still working on this or shall we either
- Close this issue.
- Transfer to someone else with explicit instructions on what needs to happen from you.
@Geeks-Sid are you still working on this?
hey @Geeks-Sid are you still on this?
hey @Geeks-Sid can you please confirm if you are still working on this or shall we either
- Close this issue.
- Transfer to someone else with explicit instructions on what needs to happen from you.
@Geeks-Sid please respond.
Sorry but this has completely skipped my notifications for some reason. Currently the code is way behind master and therefore cannot be Merged into the current PR anymore. Additionally, as I currently resolving some training issues, it would be unwise to change any model code until absolutely necessary. I will pick this Issue later as I resolve the current training issues.