GaNDLF
GaNDLF copied to clipboard
Update test workflow with file path filtering
Fixes #ISSUE_NUMBER
Proposed Changes
- Add path-ignore filtering to the test workflow so that it doesn't run only on doc changes. Keeping it minimal because other files (e.g. MANIFEST.in) could actually end up affecting the build.
- ( This is a draft because I need to check how this works with codecov).
Checklist
- [x] I have read the
CONTRIBUTING
guide - [x] My PR is based from the current GaNDLF master
- [x] Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change
- [x] Function/class source code documentation added/updated
- [x] Code has been blacked for style consistency
- [x] If applicable, version information has been updated in GANDLF/version.py
- [x] If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
- [x] Usage documentation has been updated, if appropriate
- [x] History has been updated, if appropriate
- [x] Tests added or modified to cover the changes; if coverage is reduced, please give explanation
- [x] If customized dependency installation is required (i.e., a separate
pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]
Codecov Report
Merging #473 (7a17fe7) into master (f4c4752) will decrease coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
- Coverage 92.53% 92.51% -0.02%
==========================================
Files 105 105
Lines 6417 6417
==========================================
- Hits 5938 5937 -1
- Misses 479 480 +1
Flag | Coverage Δ | |
---|---|---|
unittests | 92.51% <ø> (-0.02%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...NDLF/data/preprocessing/template_matching/utils.py | 95.34% <0.00%> (-2.33%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Placed PR in draft pending final logic completion.
@sarthakpati @Geeks-Sid This is ready for review, after some testing on my end regarding other CI services. Everything else should run when triggered this way. As a general rule, methods for bypassing the tests should be kept to a minimum.
Do note that this still does run what is effectively build test in the form of the Docker "edge" builds.