GaNDLF icon indicating copy to clipboard operation
GaNDLF copied to clipboard

Adding connected component analysis as a post-processing step

Open Geeks-Sid opened this issue 2 years ago • 5 comments

Adds connected component analysis

Proposed Changes

Checklist

  • [x] I have read the CONTRIBUTING guide
  • [x] My PR is based from the current GaNDLF master
  • [x] Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change
  • [x] Function/class source code documentation added/updated
  • [x] Code has been blacked for style consistency
  • [x] If applicable, version information has been updated in GANDLF/version.py
  • [x] If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
  • [x] Usage documentation has been updated, if appropriate
  • [ ] History has been updated, if appropriate
  • [x] Tests added or modified to cover the changes; if coverage is reduced, please give explanation
  • [x] If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

Geeks-Sid avatar Aug 10 '22 21:08 Geeks-Sid

Codecov Report

Merging #467 (8b3fc08) into master (be60609) will increase coverage by 0.13%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
+ Coverage   93.18%   93.32%   +0.13%     
==========================================
  Files         104      104              
  Lines        6458     6484      +26     
==========================================
+ Hits         6018     6051      +33     
+ Misses        440      433       -7     
Flag Coverage Δ
unittests 93.32% <100.00%> (+0.13%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
GANDLF/compute/forward_pass.py 93.39% <100.00%> (+1.28%) :arrow_up:
GANDLF/data/post_process/__init__.py 100.00% <100.00%> (ø)
GANDLF/data/post_process/morphology.py 100.00% <100.00%> (ø)
GANDLF/data/post_process/tensor.py 100.00% <100.00%> (ø)
GANDLF/parseConfig.py 77.32% <100.00%> (+0.57%) :arrow_up:
GANDLF/utils/tensor.py 88.27% <100.00%> (ø)
testing/test_full.py 98.98% <100.00%> (+0.31%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 10 '22 21:08 codecov[bot]

Please also add a note in HISTORY that suggests that "connected component analysis is now added as a post-processing step".

sarthakpati avatar Aug 15 '22 15:08 sarthakpati

Anything pending for this @sarthakpati ?

Geeks-Sid avatar Aug 23 '22 12:08 Geeks-Sid

Can we resolve the conflicts in history.md?

AlexanderGetka-cbica avatar Aug 23 '22 22:08 AlexanderGetka-cbica

Anything pending for this @sarthakpati ?

Codacy errors.

sarthakpati avatar Aug 24 '22 18:08 sarthakpati

Hey @AlexanderGetka-cbica, since I have added commits for this PR, I should not review it. Leaving for you to review.

sarthakpati avatar Sep 14 '22 17:09 sarthakpati

@sarthakpati you will need to resolve your previous review.

AlexanderGetka-cbica avatar Sep 15 '22 06:09 AlexanderGetka-cbica