web-llm icon indicating copy to clipboard operation
web-llm copied to clipboard

[Technical Debt] getConversation is repeated code

Open DavidGOrtega opened this issue 1 year ago • 1 comments

I do not quite follow the reason of having to define getConversation counterpart of c file.

I suggest to remove all the code just creating a Conversation with the config file. Is there any time that we are not going to receive one?

I would probably also keep all the templates in a json file that can be read by c, python or whatever

DavidGOrtega avatar Feb 03 '24 20:02 DavidGOrtega

A more lightweight way of adding conversation template is indeed something we've been discussing and plan to bring soon https://github.com/mlc-ai/mlc-llm/issues/1485

CharlieFRuan avatar Feb 04 '24 16:02 CharlieFRuan