mlc-llm icon indicating copy to clipboard operation
mlc-llm copied to clipboard

[Bug] `system-lib-prefix` would be cleared if `device` is not strictly `android` while `mlc_llm compile`

Open BitCircuit opened this issue 1 year ago • 2 comments

🐛 Bug

Hi there, thank you so much for your great work. I am new here, sorry if this is silly. I have met this problem while converting a LLM for a GPU enabled Android device via Python APIs. While in mlc_llm compile stage, if I set device to android:adreno (I assume it won't invoke Adreno GPU if I simply set it to android, right?), it will trigger this code and clear the system-lib-prefix. For my own case, I would just comment them out. But in my opinion, this logic does not make sense, and that's why I am submitting this report.

BitCircuit avatar Apr 30 '24 17:04 BitCircuit

passing in android would be fine, and it will invoke adreno GPUs.

tqchen avatar Apr 30 '24 17:04 tqchen

After reading through the code, i think @BitCircuit you are right and we can safely remove this line, do you mind send a PR?

tqchen avatar Apr 30 '24 17:04 tqchen