Martin Lange
Martin Lange
This may not be needed. See this suggestion: https://github.com/mlange-42/git-graph/pull/71#issuecomment-1623253021
🤔 Any idea how I can approve the CI to run? Or why I can't? No such option anywhere... EDIT: Ok, seems it is becaused actions are restricted to `push`....
Ok, fixed. Could you rebase onto `main` please?
GLFW dependencies are missing. They need to be installed before the benchmarks run. See here for an example: https://github.com/mlange-42/arche-pixel/blob/main/.github/workflows/tests.yml#L24
No, it is required for the failing jobs in `benchmarks.yml`.
Yeah, I would try to avoid such dependencies where possible, esp. if it includes something as heavy as OpenGL.
Mh, another error around GLFW. But this time, it should not happen when just importing it. It looks like Ebiten actually does some GLFW stuff. I got this error only...
@sedyh Finally, I found a way to circumvent the problem of no display in the CI runners. There is `xvfb`, which emulates a display. Here is an example how to...
> Yeah... if we are going to merge that, then, probably, only in a separate branch, so as not to litter with additional dependencies? Or it will just better to...
Another thing I notice while preparing the plots is that something in your PR (a dependency?) is slowing down some of the benchmarks, particularly in the `Build` category. Not sure...