ml5-library icon indicating copy to clipboard operation
ml5-library copied to clipboard

Published 20 hours ago • verified publisher icon ml5js

Add MoveNet

Open harsha7addanki opened this issue 3 years ago • 2 comments

Dear ml5 community,

The Pull Request Adds MoveNet(A Faster Version Of PoseNet ) It Uses A Very Simplistic Api And Is Not Too big

harsha7addanki avatar Aug 30 '21 17:08 harsha7addanki

@harsha7addanki , this won't work. You have a dependency clash to resolve. And, you have not imported poseDetection in the MoveNet/index.js file. It has not extended EventEmitter. You can't call .on('pose',()=>{}) just like you would on the ml5 poseNet module. Please review your code and then submit a pull request next time.

titanventura avatar Jan 08 '22 14:01 titanventura

@harsha7addanki thanks for taking the time and submitting the PR. Could you please verify and implement what @titanventura mentioned. I everything is resolved and works, we are more than happy to accept the PR.

Also feel free to join our Discord: https://discord.gg/guqTmsuQ User afogel is working on implementing media-pipe as well. Maybe you can work on this together.

tlsaeger avatar Jan 10 '22 10:01 tlsaeger