[Feature] Support pickling array for bfloat16

Open awni opened this issue 1 year ago • 7 comments

Leaving this here in case someone wants to pick it up.

Mar 06 '24 16:03 awni

I would be interested.

Apr 06 '24 18:04 MacOS

Great!! Send a PR?

Apr 08 '24 14:04 awni

I will! :)

May I ask you to assign the issue to me so that it appears on my GitHub landing page and reminds me to do it ASAP?

Apr 08 '24 18:04 MacOS

@MacOS are you still working on this? If not I would be happy to take it up :) cc: @awni

Apr 30 '24 16:04 AvikantSrivastava

Go for it @AvikantSrivastava

Apr 30 '24 16:04 awni

@awni I was referring to this PR https://github.com/ml-explore/mlx/pull/713/files for the implementation of pickle bindings. It seems that this piece of code was later removed, can you point me to the pickling implementation?

May 01 '24 20:05 AvikantSrivastava

Just that: https://github.com/ml-explore/mlx/blob/main/python/src/array.cpp#L672-L684

May 01 '24 21:05 awni