mlx-swift icon indicating copy to clipboard operation
mlx-swift copied to clipboard

.strides property is misleading -- PR #96 changes affected our implementation

Open jkrukowski opened this issue 7 months ago • 13 comments

I'm a contributor to WhisperKit repo. We're trying to adopt mlx-swift so it can work side by side with coreml implememtation. When updating mlx-swift to the latest version (0.16.0) our whipser mlx pipeline started working incorrectly.

Details:

  • the last working commit is d6d9472da5bf7ec2654e8914bd1d15622f45b6a9 seems like 36d63a1fc386a551df14f5b67df1756dc17d2ebc broke something (this PR https://github.com/ml-explore/mlx-swift/pull/96)
  • I suspect it might be related to the functions which allow conversion between MLXArray and MLMultiArray types, these functions are here:

Not sure what's wrong here, I'd be grateful for any advice, thanks!

jkrukowski avatar Jul 23 '24 14:07 jkrukowski