slugify icon indicating copy to clipboard operation
slugify copied to clipboard

Add missing character 'ی'

Open hsharghi opened this issue 6 years ago • 5 comments

hsharghi avatar Dec 09 '19 08:12 hsharghi

This is surprisingly hard to look up, but it seems like it's this here.

BrettRToomey avatar Dec 09 '19 10:12 BrettRToomey

Looks like it can be both Î and Y

BrettRToomey avatar Dec 09 '19 10:12 BrettRToomey

Looks like it can be both Î and Y

The character 'ي' was properly set in replacement dictionary. But the character 'ی' was not exist in the dictionary at all, and the latter character was being replaced with '-' when slugify() the word.

hsharghi avatar Dec 15 '19 08:12 hsharghi

The change is fine but CI is breaking. Could you try and update .circleci/config.yml and change the line xcode: "9.0" to `xcode: "9.2"?

Should I change the config.yml file?

hsharghi avatar Dec 15 '19 17:12 hsharghi

@hsharghi yes please, that should fix the CI build

siemensikkema avatar Jan 07 '20 11:01 siemensikkema