Matthias Kurz

There are some interesting comments in the Electron code: - https://github.com/electron/electron/blob/v33.3.0/shell/browser/native_window_views.cc#L303-L304 - ➡️ https://github.com/electron/electron/blob/v33.3.0/shell/common/platform_util.h#L64-L66 - ➡️https://github.com/electron/electron/blob/v33.3.0/shell/common/platform_util_linux.cc#L426-L438 (here it make sure the desktop file name matches ☝️) - ➡️https://github.com/electron/electron/blob/v33.3.0/shell/browser/api/electron_api_app.cc#L930-L935 - This...

I will use latest 2.18.3, I just kept this PR open as reminder. We always update to the latest patch releases.

- #13366

> Edit: actually, this default would be the best of both worlds Yeah, I think this is the best solution. This basically restores sbt 1.4.0 behaviour (for Assets, at least),...

> but this PR is just an issue, with a code example, isn't it? No, this is not just an issue, it's also an actual pull request with the change...

> I'm not sure if there is a misunderstanding here but Ebean has 2 types of DDL generation: @rbygrave This is what we do currently: https://github.com/playframework/play-ebean/blob/main/play-ebean/src/main/java/play/db/ebean/EbeanDynamicEvolutions.java#L118-L137 Is that OK? (I...

@rbygrave One more thing: I do think about that our play evolutions script parser should eventually become smart enough to understand stored procedures. However, I want to make that bullet...

> Would you consider merging my PR **with a naming of the comments that you choose**? Just an idea, something like: ``` ... BEGIN -- ebean-orm-sproc-body-start ... -- ebean-orm-sproc-body-end END...

@rbygrave So I updated the pr with `-- ebean-orm-sproc-body-[start|end]`. This is now agnostic to any framework, its just ebean meta data. What do you think?

@mkurz Any thoughts?