Matthias Kurz

Results 1122 comments of Matthias Kurz

Looking at this now, this is bascially the last thing blocking us before cutting a RC for Play 2.9

This got fixed by #11833, so the https port will not be bound anymore when running tests. This is part of making JDK 20 work as well: #11747. Another proof...

Renaming the method alone doesn't really help, since that doesn't magically make path + query string binding work at the same time. I am closing this PR for now since...

@felipebonezi I reviewed once more and pushed a couple of commits onto our commit, I hope you don't mind (you just need to run git fetch to get my changes)....

@morellik thank you very much, however I merged #11509 instead which also contained tests and docs updates.

Could not re-open this pull request, so I had to create a new one: - #12477

@gaeljw thanks again. So finally, lets do this. I updated the pull request so it * also handles milestone and rc releases (e.g. `2.9.0-M1` correctly becomes `2.9.0-M2` instead of `2.9.1-M1`)....

Now that we merged that into the master branch the publish job [now publishes](https://github.com/playframework/playframework/actions/runs/3991195966/jobs/6845723528) M3 snapshots (the last version we tagged in the repo off the main branch is 2.9.0-M2):...