Matthias Kurz

Results 1121 comments of Matthias Kurz

One more thing: Would it also make sense to shut down the LoggerConfigurator in the various test helpers Plays provides? E.g. here, after the app was stopped? https://github.com/playframework/playframework/blob/44886b0607f7b5a37a4f475b6c32e23cbcef1297/testkit/play-test/src/main/java/play/test/WithApplication.java#L52-L58

@kijuky The `shutdown-downing` scripted test is flaky, it's not your fault 😉 I restarted it

@kijuky Are you able to continue to work on this pull request? Like Greg said, just add the other changes as well, it's fine. Thanks!

> Note: I didn't update the persistence.xml file in the `play-java-jpa/src/test/resources/META-INF`, if requested, I can also update it to 2.2. I think that would make sense now.

If you mean https://github.com/playframework/playframework/blob/master/dev-mode/sbt-plugin/src/sbt-test/play-sbt-plugin/distribution/conf/META-INF/persistence.xml then I don't think that is necessary. It's empty and AFAIK it's only used for testing dist packages.

Yes, please update it as well. Let's keep everything as much up to date as possible. Thanks!

@takapi327 There are still problems, please see here: https://github.com/playframework/playframework/runs/6385057076?check_suite_focus=true

> Are there any potential compatibility issues with this upgrade? I already added a TODO in the migration guide, refering to this blog post: https://thorben-janssen.com/migrating-jpa-2-x-to-3-0/ > ... JPA 3.0 brings...

@cunhazera Login where? It seems that is a problem specific to your source code. Is it possible to provide a small project which reproduces the problem? Thanks!