ESPN-Fantasy-Football-API
ESPN-Fantasy-Football-API copied to clipboard
Add ability to retrieve basic matchup scores for a season
Would like to have changed the Boxscore class to extend the MatchupScore class, but not sure it would improve readability or reduce duplication, so left it alone.
Integration tests are currently failing as the snapshot in the repo is out of date. Not certain what needs doing to update the snapshot.
Integration tests are currently failing as the snapshot in the repo is out of date.
Doesn't look like this is the reason for failing actually. All the tests that use the seasonId
parameter are failing with a 400 response.
Edit: Or maybe it's just because I wasn't setting the leagueId
and authentication cookies when running the tests...
Also added in the ability to fetch basic team data for a season, without including roster data.
These Code Climate failures are very annoying. At some point some level of duplication is fine! Any suggestions on what else to do to get it to accept the code?
Codecov Report
Merging #157 into master will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #157 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 14 +1
Lines 181 203 +22
Branches 25 28 +3
=========================================
+ Hits 181 203 +22
Impacted Files | Coverage Δ | |
---|---|---|
src/client/client.js | 100.00% <100.00%> (ø) |
|
src/matchup-score/matchup-score.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ead02ed...04cfbe8. Read the comment docs.