Cleanup codebase, create v1
Thanks for a great port of the Github library.
I'm offering this PR to cleanup a few things in the codebase, to make them a bit more friendly to what a node.js dev would expect in 2016. Here's a summary of the changes:
parse_replyrenamed toparse.String.prototypeis no longer augmented, instead we use local functions for performingtrim,chomp, etc.- The module is exported directly, meaning you get the whole module when you
require('emailreplyparser'). - Test dependencies added to
package.jsonto make testing easier. underscorereplaced withlodashin the tests.- Code style cleaned up: use single quotes everywhere, add
'use strict'definitions, use triple equals where necessary.
I hope this is acceptable, if not then I'm happy to maintain my fork and publish to npm under a different name.
@fiznool Did you fork and publish to npm under a different name?
@CTassisF the changes are still in my fork at https://github.com/flowxo/emailreplyparser
I didn't publish anything to npm yet. If @mko doesn't reply in the next few weeks I'll look to do that. In the meantime you can depend on my fork directly. In your package.json:
"emailreplyparser": "github:flowxo/emailreplyparser#0834875