javascript-errors icon indicating copy to clipboard operation
javascript-errors copied to clipboard

Published 20 hours ago • verified publisher icon mknichel

example update

Open Jocs opened this issue 9 years ago • 1 comments

Hi, mknichel, I really like this article, and have used some examples in my javascript error track project, thank you for your great work on javascript error. but when i rewrite the Promise.prototype.then method, I found that my '.catch' can not catch error, so I think we should rethrow the error in catch block of 'protectEntryPoint' function. One more thing, when we use the 'protectEntryPoint' function, we should check the arguments type, and make sure its 'function' type. Thank you again for you article, I have translated a Chinese version, if you prefer a Chinese version, I'll PULL another request.

Review on Reviewable

Jocs avatar Jan 30 '16 18:01 Jocs

Hi Jocs,

Thanks for the pull request! I left a few comments in the code.

A Chinese translation sounds great - do you want to submit a separate pull request for that?

mknichel avatar Feb 07 '16 05:02 mknichel