Marko Mikulicic

Results 231 comments of Marko Mikulicic

Blocked on #139

yes; more explicitly: it's likely that if this library doesn't do it, the users of this library won't do it either and thus effectively their application won't be compliant with...

@glyn I implemented (d), PTAL

@glyn > let mut d = Decoder::read(file) > let mut e = d.encoding_trap(mytrap) > let f = d.decode() I'm not a rust expert but that's not how this builder pattern...

CI fails because of a transient error ``` error: caused by: failed to make network request error: caused by: error sending request for url (https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256): error trying to connect: dns...

Sorry, I don't understand. This code works: ``` pub fn encoding_trap(self, trap: encoding::types::DecoderTrap) -> YamlDecoder { let mut new = self; new.trap = trap; new } ``` if I understand...

The [YAML spec, section 9.1.1](https://yaml.org/spec/1.2/spec.html#id2800168) states: ``` A document may be preceded by a prefix specifying the character encoding, and optional comment lines. Note that all documents in a stream...

Indeed, but I thought to file a separate issue for that (as it would likely mean a new API). If I understood correctly, the current API takes a rust string,...

Forked the thread about encoding detection in #155.