vscode-remote-workspace icon indicating copy to clipboard operation
vscode-remote-workspace copied to clipboard

Remote Workspace Search

Open dacowan opened this issue 6 years ago • 17 comments

This extension is exactly what I was looking for, but it has one major missing functionality issue...

Any file opened from the workspace (or files IN the workspace) are not searched when running a "Find In Files" search.

Is this a problem with the remote filesystem API or the search service?

E.g. If I define a remote workspace on to an Ubuntu machine, using sftp - although I can browse and open files through the workspace GUI -- any attempt to search/find in files fails with "nothing found" (even files open in the editor)

dacowan avatar Jun 07 '18 17:06 dacowan

@dacowan

Unfortunately this is currently not implemented yet, but since 1.24, it is released as so called "proposed api", as you can read here.

Because it is a very important feature, I will have an eye on it and I hope that I can provide it with Visual Studio Code 1.25 or 1.26 in the next one or two months, when it becomes a "real api".

mkloubert avatar Jun 07 '18 17:06 mkloubert

Thank you so much! Happy to help debug if you implement a beta.

dacowan avatar Jun 07 '18 17:06 dacowan

@dacowan

Great idea!

I can start develop the new feature now and I will provide betas the in the release section, so you can download them as VSIX files and install them manually.

The problem with extensions, which are using "proposed apis", cannot published to the market place, but I think that "the manual way" is OK :-)

mkloubert avatar Jun 07 '18 17:06 mkloubert

@dacowan

BTW.: What protocols you are currently using?

mkloubert avatar Jun 07 '18 18:06 mkloubert

Primarily SFTP for now, but I could reconfigure my workflow to test FTPS, Azure or Dropbox. I won't be able to test S3 though.

Downloading a VSIX is not a problem either.

dacowan avatar Jun 07 '18 18:06 dacowan

@dacowan

I released a first preview.

There is described how to install the VSIX file and to setup your VSCode instance.

mkloubert avatar Jun 08 '18 01:06 mkloubert

Excellent work. It appears to work (on SFTP at least, I haven't tested the others yet). Thank you.

Some potential improvement suggestions: (And I haven't looked at the code or API yet to see if these are possible - I'm just riffing off the top of my head from my 5 minutes cursory glance... please feel free to tell me where to go ;) )

  • Prioritize the open editor files first (chances are, the stuff I'm searching for is already open locally in an editor window)
  • Cache the filesystem contents so that "files to include" can filter out the search list faster than enumerating down through the remote filesystem hierarchy

Errr... that's all I can really think of, short of caching and indexing the remote filesystem for faster text searching - which is somewhat beyond the scope of the extension..

I'll have free time next week going forward in the evenings if there's stuff that you need help with... this extension will save me a metric shed-load of time and effort in my daily life, so I'm happy to contribute.

dacowan avatar Jun 08 '18 15:06 dacowan

@dacowan

I have released a new preview 0.26.0 with caching.

mkloubert avatar Jun 11 '18 01:06 mkloubert

OK, now you're just showing off. :)

dacowan avatar Jun 11 '18 18:06 dacowan

Great Extension! And I also appreciate a search functionality!

trevorkloz avatar Jun 12 '18 14:06 trevorkloz

@dacowan @trevorkloz

Unfortunatly the search API has not arrived yet in version 1.25.

I hope this will happen next month, in the upcoming release.

Are there currently any (new) issues?

mkloubert avatar Jul 05 '18 23:07 mkloubert

None that I've seen... I've been using it daily just about, since 0.26.0 The only problem I've had is when it auto-upgrades behind the scenes - but I turned that off.

dacowan avatar Jul 05 '18 23:07 dacowan

Any updates on this? has the search API arrived yet?

ryanerrington avatar Oct 01 '18 14:10 ryanerrington

@ryanerrington

Currently not ... I hope for the upcoming month release, so I will be able to integrate the code of the branch file_search.

BTW.: I started to work with the propsed API, which allows to integrate an own virtual terminal, in branch remote_terminal. If it has been changed to a "ready to use" API, you will also be able the execute commands via SFTP and FTP directly from a terminal window, as you know it from bash and PowerShell.

mkloubert avatar Oct 03 '18 16:10 mkloubert

I thank you for your good work. Can you keep your preview release in sync with your stable release?

Raamakrishnan avatar Oct 09 '18 06:10 Raamakrishnan

Having this problem with sftp. Any update on this?

soynomm avatar Nov 10 '18 23:11 soynomm

Hi,

I'm on VSCode 1.34.0-insider and have vscode-remote-workspace 0.26.0 pre-release installed. I was expecting to be able to open SFTP files by name via ctrl+p, however the SFTP files do not show up.

I have followed the instructions on starting Code.exe --enable-proposed-api mkloubert.vscode-remote-workspace and manually installing the VSIX file.

Any idea if this is possible? Thank you.

bilogic avatar Apr 06 '19 00:04 bilogic