vscode-deploy-reloaded
vscode-deploy-reloaded copied to clipboard
mkloubert
Pull only gets the first 65,536 bytes of the file
Description
When pulling files which size is more than 64 KB, deploy will only get the first 65,536 B of that file, thus leaving file incomplete. No errors displayed either on the bottom right popup or the output tab.
Steps to reproduce
Pull any file that is more than 64 KB.
Example config
{
"deploy.reloaded": {
"targets": [
{
"type": "sftp",
"name": "Server Name",
"description": "The Server Description",
"host": "server.com",
"dir": "/path/to/success.com",
"user": "vlasscontreras",
"privateKeyPassphrase": "64SeemsToBeTheAnswerInsteadOf42",
"privateKey": "~/.ssh/id_rsa",
},
],
"packages": [
{
"name": "Pull",
"button": {
"text": "Pull File",
"tooltip": "Click here to pull the current file",
"command": "extension.deploy.reloaded.pullFile"
}
},
{
"name": "Push",
"button": {
"text": "Push File",
"tooltip": "Click here to push the current file",
"command": "extension.deploy.reloaded.deployFile"
}
}
],
}
}
Logs
INFO extension.deploy.reloaded.loadplugins - [19/Feb/2019:19:57:25 +0000] "Loaded 19 plugins:
- app
- azureblob
- batch
- compiler
- dropbox
- each
- ftp
- list
- local
- mail
- map
- prompt
- s3bucket
- script
- sftp
- slack
- switch
- test
- zip
"
WARN workspaces.workspace.reloadpackagebuttons() - [19/Feb/2019:19:57:26 +0000] "Button of package 'Pull' will use the existing command 'extension.deploy.reloaded.pullFile'."
WARN workspaces.workspace.reloadpackagebuttons() - [19/Feb/2019:19:57:26 +0000] "Button of package 'Push' will use the existing command 'extension.deploy.reloaded.deployFile'."
Your environment
- Operating system: Windows 10 & macOS 10.14.3
- Visual Studio Code version: 1.31.1
- Extension version: 0.87.2
PLEASE FIX THIS!!!! NOT NOTICING THIS CAUSE ANOTHER 65k+ BYTES MISSING AND NO WAY TO GET THAT BACK!!!!! PLEASE FIX RIGHT AWAY!!
To add detail, this happens with any operation with a SFTP target (push, pull, compare). Only the first 64KB of the file is used, which is kind of harmless when comparing or pulling a file, but can be "entertaining" if pushing a file to a remote and finding out that the file was truncated even though the plugin confirms the operation as successful.
@mkloubert Obviously we can't demand you to use your time and effort to fix this for our benefit, nevertheless would be very grateful just in the same way as I'm (we are?) hugely grateful for this excellent and extremely useful plugin, which for me is a must-have for VSCode and I always recommend. If you can, please give a look at this issue! Thank you in advance.
For anyone interested in an alternative, take a look at the official Remove Development extension, and the docs about remote SSH connections.
Any updates to this issue ?
We still have the problem and couldn't pull anything bigger. From this point the extension becomes some useless :(
