pyodbc
pyodbc copied to clipboard
mkleehammer
Add interval support
I plan to submit a patch to fix support for intervals, particularly with a Vertica backend. Is there anything in particular I should read before submitting my patch? Perhaps regarding code style, licenses, etc?
I made a Google Groups post here but I am not sure if that is monitored much.
Sorry, I have been so busy on so many projects that I haven't been monitoring the group much. As for style, just try to match the rest of the code. Thanks.
No problem. Since I do not see many helper functions in src/getdata.cpp, do you have a particular style in mind?
I'm not really sure what your looking for, so feel free to start the pull request. I alway recommend rebasing to a single commit anyway, so if you feel changes are needed afterwards it will end up fine.
I was assuming we were talking about the generic ODBC interval data type and you creating a Getinterval function or something. Did I get that right?
Somewhat related: what do you want get_version() to report when not on a branch? Right now, since git branch shows * (no branch), it reports something like 3.0.13b1+(no, which is a) poorly formatted and b) messing up the TOSTRING macro. I propose a change that instead uses the commit hash when not on a branch.
I thought I fixed that once by replacing it with no-branch, but a hash would be great. Thanks.
My intention is to ways be on a branch when developing so I ignored the few times I was using hit bisect, etc
Yay! https://github.com/mkleehammer/pyodbc/pull/66 https://github.com/mkleehammer/pyodbc/pull/67
Interesting.
2015-09-25 16:48 GMT-04:00 Matthew Weaver [email protected]:
Here's another attempt: #80 https://github.com/mkleehammer/pyodbc/pull/80
— Reply to this email directly or view it on GitHub https://github.com/mkleehammer/pyodbc/issues/60#issuecomment-143349621.