dropbear icon indicating copy to clipboard operation
dropbear copied to clipboard

Build system changed in 2024.86

Open duhow opened this issue 1 year ago • 5 comments

Building from 2022.83 to 2024.86 , I had to do some changes to fix the build system. Just pointing this out, as I was facing this error:

configure: error: cannot find install-sh, install.sh, or shtool in "." "./.." "./../.."

The fix done to build is this:

 configure_package() {
@@ -13,11 +13,19 @@ configure_package() {
 
        CC=${BUILD_CC} LDFLAGS="${BUILD_LDFLAGS}" ./configure \
                 --build=${MACHTYPE} --host=${BUILD_TARGET} --target=${BUILD_TARGET} --prefix=${INSTALL_PREFIX} \
+                --srcdir=src \
                 --disable-zlib
 }
 
+premake_package() {
+       echo_notice "Patching config"
+       sed -i 's!src/src!src!g' Makefile
+       ln -sv ../libtommath src/libtommath
+       ln -sv ../libtomcrypt src/libtomcrypt
+}

duhow avatar Dec 12 '24 22:12 duhow

It should be also looking in src/ because that's set as AC_CONFIG_AUX_DIR. https://github.com/mkj/dropbear/blob/master/configure.ac#L892

In my config.log I see:

configure:2828: looking for aux files: install-sh config.guess config.sub
configure:2841:  trying ./src/
configure:2852:   ./src/install-sh found
configure:2870:   ./src/config.guess found
configure:2870:   ./src/config.sub found

Is there anything unusual about your system?

mkj avatar Dec 13 '24 00:12 mkj

Other than running autoreconf -fi and this is a cross-build, I don't think there are more changes.

See file here, I will attach a build log later on

https://github.com/duhow/xiaoai-patch/blob/0d3ed64706c7bed3ff81a93b1ff6c5b16d0d4428/packages/dropbear/package.mk

duhow avatar Dec 13 '24 08:12 duhow

Which autoconf version is it? If you can attach the regenerated configure script that might give a clue too.

mkj avatar Dec 13 '24 08:12 mkj

autoconf (GNU Autoconf) 2.69

configure config.log

duhow avatar Dec 13 '24 08:12 duhow

It looks like autoconf changed AC_CONFIG_AUX_DIR behaviour in 2.70, https://git.savannah.gnu.org/gitweb/?p=autoconf.git;a=commit;h=4c59bf27d7083088290219450c81d999431b43f1

I'll bump Dropbear's autoconf requirement to 2.70, in your case I guess you can just avoid running autoreconf at all and just use the pregenerated configure in the repo/tarball.

mkj avatar Dec 13 '24 12:12 mkj