linked-list-good-taste

linked-list-good-taste copied to clipboard

Here are some trivial commits. I believe I already sent one of these, but here it is again so it doesn't get lost.

felipec

A question about the implementation

3

As knowing the node to remove, why traverse the linked list instead of doing something such as: ```c target->value=target->next->value; target->next=target->next->next; ```

Dan-k391

I found out the **p can be removed, which leads to lesser codes, but I don't know whether it's better or worse since it introduces a warning, what do you think?

2

with `**p`: ```c static inline list_item **find_indirect(list *l, list_item *target) { list_item **p = &l->head; while (*p != target) p = &(*p)->next; return p; } ``` without `**p`: ```c static...

Camio1945

TaivasJumala

This project doesn't seem very active, and I created a much improved version of this that uses GitHub Pages and coded diagrams, so I think the efforts should be concentrated...

felipec

If target isn't in the list, `find_indirect` will walk off the end and dereference NULL. Example: ``` list_item item1 = { 3, NULL }; list_item item0 = { 1, &item1...

olawlor