Maxim Khon

> For the `request->log.unlang_indent` assertion, the short-term fix is to just delete it. It's a sanity check on indentation for the current request. It doesn't affect how the server operates...

I believe I found the reason for these use-after-free: in `fr_ldap_trunk_search()` and `fr_ldap_trunk_modify()` `fr_ldap_query_t` is allocated with `ctx = unlang_interpret_frame_talloc_ctx(request)` (frame context). Then `ldap_trunk_query_cancel()` can be called in this context:...

@arr2036 @ndptech Re: initial bug report There are several issues in lib/ldap: 1. two cancellation handlers in `fr_ldap_trunk_search()`: why do we need to set `_ldap_search_sync_timeout()` handler at all? This was...

I should note that with the patches from #4628 I no longer see the crashes and aborts. But after several million requests with LDAP authorization all the workers got stuck...

> This is the issue the timeout event was added to prevent. I was seeing exactly the same deadlocks on a production server. @arr2036 which issue? Seems that the link...

@arr2036 if I am not mistaken most of the issues here are fixed now except use-after-free for `fr_ldap_query_t`. If I am not mistaken you mentioned you will provide a better...

> This would break local builds for us. It'd be better to figure out the prefix map for your situation. How do you run your local builds? Is there -g...

Can you please re-check on latest CentOS 7? Because this is 100% reproducible on my CentOS 7 build machines I will try to test on Rocky 8

In the meantime you can see the configure arguments I used here: microsoft/vcpkg#22810 This is msys2 + configure + MS VC build. vcpkg sets up its own environment and also...

> This PR has been marked "do not merge" since we are no longer accepting PRs into the `master` branch. All new PRs should be made on the `devel` branch...