videojs-share icon indicating copy to clipboard operation
videojs-share copied to clipboard

Clicking on Close (x) icon throws a JS error in the console

Open synergies opened this issue 6 years ago • 1 comments

When you click on the Close (x) icon, it throws the following JS error:

video.js:498 VIDEOJS: ERROR: TypeError: Cannot read property 'trigger' of null
    at e.close (videojs-share.min.js:7)
    at CloseButton.bound (video.js:2348)
    at HTMLButtonElement.bound (video.js:2348)
    at HTMLButtonElement.data.dispatcher (video.js:1971)
    at trigger (video.js:2103)
    at CloseButton.trigger$$1 [as trigger] (video.js:2964)
    at CloseButton.handleClick (video.js:12956)
    at HTMLButtonElement.bound (video.js:2348)
    at HTMLButtonElement.data.dispatcher (video.js:1971)

synergies avatar Dec 12 '18 15:12 synergies

@synergies Yep, it is possible on this line.

https://github.com/mkhazov/videojs-share/blob/fb04cff70a5f0e73450aa9560a49a64432616af2/src/ShareModal.js#L26

You can try to fix it and make PR. :)

avdeev avatar Dec 12 '18 15:12 avdeev