Mohammad Kermani comments

Results 37 comments of


                                            Mohammad Kermani

getStateValidators does not dedupe validators

@nflaig Yeah, it seems a better solution. I can work on it nonetheless. This may need a bit of conversation. Should I leave comments here, or open a thread on...

Verification of `eth_getBlockNumber` for prover should not forward request

Is it sufficient/correct to create a new verified request for `eth_blockNumber` and use `getHead` of light client to fix it?

Optional randao verification when producing blocks

This seems already part of this client. https://github.com/ChainSafe/lodestar/blob/011a0c4b89250b8fdc56a86f9b0a4698521554d0/packages/api/src/beacon/routes/validator.ts#L315

Optional randao verification when producing blocks

> it's there but we don't actually use it, meaning we never verify the randao right now Should we verify the reveal against the proposer to implement this?

Optional randao verification when producing blocks

@nflaig I investigated it a bit. Based on your comment, I thought the whole Randao verification is absent in Lodestar, but noticed that all the required code is already there:...

Optional randao verification when producing blocks

I can work on this. Got a grasp of the requirements.

Optional randao verification when producing blocks

I opened a draft PR, so that you can confirm or comment on the overall implementation. After that, I can add some tests, etc. if needed.