Matthew Kenigsberg
Matthew Kenigsberg
Beware of merge conflicts with https://github.com/flox/flox/issues/2130
> Can this ticket even be worked on in isolation, considering that the concept of attach is not currently represented in the activate script? We do in some sense already...
I haven't been able to reproduce that error specifically but have run into some other issues building that flake. I'm not sure yet if there's a Flox issue or if...
I think testing should be relatively straightforward for what this command does, but it might get more complicated once we need to test it in integration with the rest of...
Questions: - The watchdog will need to poll the registry. When will it do that? Periodically? Only when it's deregistering a PID? - Should the watchdog monitor the PIDs of...
- Should the watchdog update the activations.json file every time it notices a PID exits? Or just maintain a list in memory?
> We'll need to make sure that `flox-watchdog` tracks new activation PIDs as they are added to `activations.json` by `flox-activation` otherwise we might trigger clean-up too early if `flox-watchdog` doesn't...
- We'll need to change the watchdog to use FLOX_ENV instead of .flox
Split into https://github.com/flox/flox/issues/2205 and https://github.com/flox/flox/issues/2206
> Duplicate these from the SDK, e.g. [path_hash()](https://github.com/flox/flox/blob/52df88e4cc2454d52b78d0aa2f183e779da57f0e/cli/flox-rust-sdk/src/models/environment/mod.rs#L689-L694)? I think we can move them from the SDK to flox-activations