Marianne Corvellec
Marianne Corvellec
> Unfortunately no, not in the foreseeable future... No worries, I completely understand! @rum1887 is there a chance you could help out with this? :wink:
I'm a little embarrassed because, with this change, existing code written as `compare_images(image1=a, image2=b)` will raise an *error* (due to `image1` being also the new name of `image2`). To avoid...
@lagru I've drawn from your class `deprecate_parameter` but, as you will see, it's a bit ugly, hard-coded, etc. :see_no_evil: I rushed to submit this, in case it could make it...
> Sorry, @mkcor I don't want to come off as devaluing your approach. All good, @lagru! I think my code wasn't very elegant, so I definitely welcome your inputs. :heart:...
Not sure we're covering all edge cases, but this implementation is definitely lighter! Thanks, @lagru. :relaxed:
Thank you for the review and for 0756a563c27cb8757d513025bea58192430f4f5c, @lagru! I just included minor fixes in the docstring (770499a42a66c5058551738bc374601a52255842).
At yesterday's community call, @lagru and I were discussing whether we should merge this (skimage2-transition--related) PR, but we refrained so as not to interfere with the 0.23 release. @jarrodmillman could...
@lagru thank you for taking care of 17cfe6477db9ead20d76a4c25526619874fd31aa! :pray:
Before I tackle the `im_true` and `image_true` instances, I wanted to check with reviewers whether I should take 5bdeed8f83d3 further: * I searched for all the user-facing instances of `image2`;...
> I for one, like to limit positional arguments to 2. :+1: as well and I believe many of us are leaning towards this preference (see #7225). To carry out...